Bugfix: make sure that every destroyed plugin handle is 'detached' (#…

…2652)
meetecho · May 4, 2021 · b003580 · b003580
1 parent 11942f5
commit b003580
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/html/janus.js b/html/janus.js
@@ -721,7 +721,6 @@ function Janus(gatewayCallbacks) {
 				// Don't warn here because destroyHandle causes this situation.
 				return;
 			}
-			pluginHandle.detached = true;
 			pluginHandle.ondetached();
 			pluginHandle.detach();
 		} else if(json["janus"] === "media") {
@@ -1679,6 +1678,7 @@ function Janus(gatewayCallbacks) {
 			callbacks.success();
 			return;
 		}
+		pluginHandle.detached = true;
 		if(noRequest) {
 			// We're only removing the handle locally
 			delete pluginHandles[handleId];