Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Plan] SDP parsing segfault on build without usrsctp #1700

Closed
Bug-Fairy opened this issue Jul 15, 2019 · 2 comments
Closed

[Unified Plan] SDP parsing segfault on build without usrsctp #1700

Bug-Fairy opened this issue Jul 15, 2019 · 2 comments

Comments

@Bug-Fairy
Copy link
Contributor

Bug-Fairy commented Jul 15, 2019 •
edited
Loading

Janus crash on Debian 10 when running echotest on Firefox.

Caused by building without usrsctp and offering data channel.
janus_handle_webrtc_medium_create(handle, JANUS_MEDIA_UNKNOWN) returns NULL when further logic expects medium to never be NULL.
https://github.com/meetecho/janus-gateway/blob/unified-plan/sdp.c#L195

Edit:
Exact crash line:
https://github.com/meetecho/janus-gateway/blob/unified-plan/sdp.c#L205
@lminiero
Copy link
Member

Thanks for spotting this, I'll have a look 👍

lminiero added a commit that referenced this issue Jul 17, 2019
@lminiero
Fixed segfault when usrsctp is not available (see #1700)
66bff68
@lminiero
Copy link
Member

Fixed in this commit 66bff68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lminiero @Bug-Fairy