Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[multristream] Unknown property 13 for preparing SDP answer #2415

Closed
amnonbb opened this issue Oct 31, 2020 · 4 comments
Closed

[multristream] Unknown property 13 for preparing SDP answer #2415

amnonbb opened this issue Oct 31, 2020 · 4 comments

Comments

@amnonbb
Copy link
Contributor

amnonbb commented Oct 31, 2020

#2211

Something happened with orientation ext in last rebase
@lminiero
Copy link
Member

I'll have a look on Monday, thanks for reporting.

lminiero added a commit that referenced this issue Nov 2, 2020
@lminiero
Fixed H.264/VP9 profiles being passed when generating audio m-line (f…
e908199 
…ixes #2415)
@lminiero
Copy link
Member

lminiero commented Nov 2, 2020 •
edited
Loading

It was not an issue of rebasing. A recent commit that had restored the ability to negotiate H.264 and VP9 profiles was passing them as arguments when generating audio m-lines too, and so they were unrecognized (13 is JANUS_SDP_OA_H264_PROFILE). It should be fixed now.

@lminiero lminiero closed this as completed Nov 2, 2020
@amnonbb
Copy link
Contributor Author

amnonbb commented Nov 3, 2020

Fix solve problem with orientation ext: it's work now. But janus log still spammed with message:
[WARN] Unknown property 13 for preparing SDP answer, ignoring...

@lminiero
Copy link
Member

lminiero commented Nov 3, 2020

Fixed.

lminiero added a commit that referenced this issue Dec 9, 2020
@lminiero
Fixed H.264/VP9 profiles being passed when generating audio m-line (f…
b04ff92 
…ixes #2415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lminiero @amnonbb