-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorrect SDP answer in the video room #2547
Comments
https://github.com/meetecho/janus-gateway/blob/master/html/streamingtest.js#L161 |
@lminiero I'm talking not about |
Then yes, a PR would be welcome: as long as you use |
I'm using such kind of naming to self describe methods as something dangerous and better not to touch right away in the method signature. But from the consistency perspective sure I will use |
- customizeSdp callback added to the handleRemoteJsep(prepareWebrtcPeer) to be able to mangle remote SDP if needed (meetecho#2547)
@lminiero you can check out the PR |
Hello guys!
I, recently, was looking for a way to set the audio bitrate in the videoroom higher (by default, it was about 32kbps). The way this could be achieved is to mungle local SDP before creating an offer to tweak audio fmtp line. For instance from this:
a=fmtp:111 minptime=10;useinbandfec=1\r\n
to this:
a=fmtp:111 minptime=10;useinbandfec=1;cbr=1;stereo=1;maxaveragebitrate=160000\r\n
So I've tried to
createOffer.customizeSdp
callback and surprisely it has no effect. So I found this #1430. And it seems to be that when we receiving an answer from janus along with remote description it has no fmtp line for an audio source at all. Hence I've experienced no changes on audio quality (monitoring over webrtc-internals).But, if I've mungled answers SDP with this dirty hack:
jsep.sdp = jsep.sdp.replace("a=rtpmap:111 opus/48000/2\r\n", "a=rtpmap:111 opus/48000/2\r\na=fmtp:111 minptime=10;useinbandfec=1;cbr=1;stereo=1;maxaveragebitrate=160000\r\n");
I've got the expected behaviour.So from my perspective it's an issue. And it could be fixed in a 2 different ways:
createOffer
doessecond option is what I've done to my code, so I've ended up with this gist
I can do a PR if it's ok, so please give some feedback on this.
And thank you for all your time.
The text was updated successfully, but these errors were encountered: