Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multistream: Janus crashed when a participant join a videoroom #2572

Closed
vuta1927 opened this issue Mar 3, 2021 · 3 comments
Closed

multistream: Janus crashed when a participant join a videoroom #2572

vuta1927 opened this issue Mar 3, 2021 · 3 comments

Comments

@vuta1927
Copy link

vuta1927 commented Mar 3, 2021

Recently our janus server sometime had been crashed when an user try join videoroom. This is trace from core dump file when janus crash: https://pastebin.com/v8bgcpmb

Looked at your codes janus_videoroom.c, I think you guys are missing check null condition in line 8825 for 'ps' variable.

@lminiero
Copy link
Member

lminiero commented Mar 3, 2021

There's no line 8825 in the multistream VideoRoom. Please try the latest changes, not older commits.

@vuta1927
Copy link
Author

vuta1927 commented Mar 3, 2021

Strangely, I can find this line in janus_videoroom.c in mutilstream branch, it has been commited 8 days ago.

} else if(ps->svc) {

@lminiero
Copy link
Member

lminiero commented Mar 3, 2021

My bad... I was looking at the master version 🤦‍♂️
You're right, we probably need that additional check over there, I'll add it shortly.

lminiero added a commit that referenced this issue Mar 4, 2021
@lminiero lminiero closed this as completed Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants