Multistream: unsubscribing using publisher mid is not working with string_ids set

[isnumanagic]

Hi,
On multistream branch, sending unsubscribe request with feed + mid fields when using string_ids does not seem to be working. After digging through the code, it seems that case is only covered when string_ids is set to false, even though that should not be a problem. Here is the problematic conditional:

janus-gateway/plugins/janus_videoroom.c

Line 8609 in 50c5600

} else if(feed_id > 0) {

[isnumanagic]

feed_id is only set when string_ids is set to false, as seen here:

janus-gateway/plugins/janus_videoroom.c

Line 8592 in 50c5600

feed_id = json_integer_value(feed);

[lminiero]

Good catch, it's very likely that this is one of the leftovers when we merged the support for string identifiers from master. I'll have a look and fix it.

[lminiero]

The above commit should fix it: I found a few other parts where it needed the fix too.