-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multistream/videoroom: data_mindex not set to the correct value #2647
Comments
Good catch! Looking at the code, I suspect this wasn't just preventing data recording, but data channel braodcasting to other subscribers as well, especially in cases where data subscribers and audio subscribers didn't match. I'll fix this as suggested 👍 |
Great, thanks. It looks like the code should also be added to janus_videoroom_multistream.c |
There's no such thing: there's just a single VideoRoom plugin. |
Apologies. That was something I was trying on my end. Thanks. |
While attempting a videoroom recording ( multistream branch ), I came across a bug on the data mjr recording. Data was being saved in the audio mjr file, instead of the data mjr file (which was blank).
Digging in further, it appears participant->data_mindex is never updated in the plugin. I was able to solve this issue with the following code:
in janus_videroom.c
The text was updated successfully, but these errors were encountered: