Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no response on datachannel unsubscribe request (multistream) #2725

Closed
kaqq opened this issue Jul 5, 2021 · 2 comments
Closed

no response on datachannel unsubscribe request (multistream) #2725

kaqq opened this issue Jul 5, 2021 · 2 comments

Comments

@kaqq
Copy link

kaqq commented Jul 5, 2021

There is no WebSocket response or ACK when unsubscribe request is sent for the data channel, however, data channel messages stop flowing.
Example JSON:

{
  "session_id": 8045770177589365,
  "handle_id": 3618270449855223,
  "body": {
    "streams": [
      {
        "feed": 6750740208640810,
        "mid": "1"
      }
    ],
    "request": "unsubscribe"
  },
  "janus": "message",
  "transaction": "652354c1-a991-45ec-b9f6-8297b99b24de"
}
@lminiero
Copy link
Member

lminiero commented Jul 6, 2021

Not an issue, and expected. Unsubscribing from a publisher for data results in no renegotiation (the data channel itself survives since you may be subscribed to other people for data, or you'll need datachannels later), so you never get any updated offer, so no event either. While we may add a placeholder ack in the future, it's not there but it's not a bug. Closing.

@lminiero
Copy link
Member

lminiero commented Jul 6, 2021

Ack updated event added in case there's no SDP changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants