-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
videoroom plugin does not set H264 profile-level-id in offer SDPs if room configuration doesn't have one set #2756
Comments
@sdroege I think explicitly setting the profile-level-id for the room with the |
Just to confirm, actually setting it in the room configuration causes it to appear in the offers. |
I can confirm the issue on the |
Looking further into this, it seems that a publisher stream video profile ( |
hi @sdroege , can you please test the attached patch on top of latest
Then build and restart janus. |
@sdroege did you have a chance to check if the patch Alessandro prepared fixes it for you too? It seems to work for us, so unless you tell us it still needs fixing we'll push it to the branch. |
I had no chance to test it yet, sorry. It looks like it should work to me, so feel free to push it. If something is still broken once I get to test it, I'll let you know! |
Ack, thanks! We'll push the fix and close the issue for the time being then 👍 |
When publishing a H264 stream to the videoroom plugin, e.g. with the following SDP (offer snippet):
the following answer is produced:
Both contain the profile-level-id as expected. All good up to this point.
When subscribing to that stream, the following offer is created by the videoroom plugin:
This does not include the profile-level-id anymore.
Firefox (88) does not seem to like that at all and produces an answer with the video stream being marked as inactive (and for some reason with VP8). With Chrome this works fine, and the same Firefox version handles H264 streams with profile-level-id just fine.
This (correctly) causes Janus to report an error:
465 Error processing SDP
.From my reading of the videoroom plugin, the profile-level-id is only ever put into the SDP if the configuration of the room has one set, which seems suboptimal.
IMHO Firefox is also too strict here, which is a bug on their side, but that the videoroom plugin is not forwarding this information (and probably other) from the publisher to the subscriber seems like not a good idea.
The text was updated successfully, but these errors were encountered: