[1.x] Failed to compile on Debian9 with --enable-post-processing

[Cossack9989]

What version of Janus is this happening on?
1.1.0(master)

Have you tested a more recent version of Janus too?
Yes, 1.0.4

Was this working before?
In 1.1.0

postprocessing/pp-h264.c: In function ‘janus_pp_h264_create’:
postprocessing/pp-h264.c:76:20: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 fctx->video_codec = codec;
          ^
postprocessing/pp-h264.c:125:6: error: ‘AVFormatContext {aka struct AVFormatContext}’ has no member named ‘url’
 fctx->url = g_strdup(filename);
   ^~
postprocessing/pp-h264.c: In function ‘janus_pp_h264_close’:
postprocessing/pp-h264.c:557:14: error: ‘AVFormatContext {aka struct AVFormatContext}’ has no member named ‘url’
  g_free(fctx->url);
       ^~
Makefile:2591: recipe for target 'postprocessing/janus_pp_rec-pp-h264.o' failed
make[2]: *** [postprocessing/janus_pp_rec-pp-h264.o] Error 1
make[2]: Leaving directory '/home/tiger/janus-gateway/src'
Makefile:1379: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/home/tiger/janus-gateway/src'
Makefile:565: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1

In 1.0.4

postprocessing/pp-av1.c: In function ‘janus_pp_av1_create’:
postprocessing/pp-av1.c:61:46: error: ‘AV_CODEC_ID_AV1’ undeclared (first use in this function)
 vStream = janus_pp_new_video_avstream(fctx, AV_CODEC_ID_AV1, max_width, max_height);
                       ^~~~~~~~~~~~~~~
postprocessing/pp-av1.c:61:46: note: each undeclared identifier is reported only once for each function it appears in
Makefile:2605: recipe for target 'postprocessing/janus_pp_rec-pp-av1.o' failed
make[2]: *** [postprocessing/janus_pp_rec-pp-av1.o] Error 1
make[2]: Leaving directory '/home/tiger/janus-gateway/src'
Makefile:1379: recipe for target 'all' failed
make[1]: *** [all] Error 2
make[1]: Leaving directory '/home/tiger/janus-gateway/src'
Makefile:565: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1

Additional context
OS: Debian9
libavformat: 57.56.101
libavcodec: 57.64.101
libavutil: 55
CC: gcc
CXX: g++

[atoppi]

libavcodec: 57.64.101

that version is from 2017, I guess anything AV1 related is missing.

[lminiero]

The check we have seems to suggest it should have it though:

#if !LIBAVCODEC_VER_AT_LEAST(57, 25)

Maybe we should fix that check. The

AVFormatContext {aka struct AVFormatContext}’ has no member named ‘url’

error instead is something different, and caused by a recent fix on broken faststart support: again probably an API change we should address with a precondition, assuming we can figure out when this API changed.

[lminiero]

The commit above should fix it. That said, for next time please do not shove a full log inline as you did: if you have to, use the details collapsed feature in github (I'll edit your post to use that shortly).

Edit: sorry, I was thinking of a different issue, nevermind!