Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Support for batched configure requests in Streaming Plugin #3238

Closed
petarminchev opened this issue Jun 28, 2023 · 3 comments
Closed

[1.x] Support for batched configure requests in Streaming Plugin #3238

petarminchev opened this issue Jun 28, 2023 · 3 comments
Labels
enhancement multistream Related to Janus 1.x

Comments

@petarminchev
Copy link
Contributor

We are very happy with the batch configure request in VideoRoom plugin - #2986.
For scaling purposes we rtp_forward to the Streaming Plugin. It would make our lives a lot easier if Streaming plugin supported batched configure requests. It is especially useful during paging - instead of sending dozens of requests to Janus, we will send only one configure request - which streams to be send: true/false. Also by looking at the VideoRoom pull request, it doesn't seem like a huge effort.
Could you consider adding batched configure requests to Streaming Plugin? We think it is a very valuable feature.

Thank you in advance!

@petarminchev petarminchev added the multistream Related to Janus 1.x label Jun 28, 2023
@lminiero
Copy link
Member

Well that patch wasn't small, and the Streaming plugin works a bit differently from the VideoRoom -- I wouldn't call it a "small effort" 😛
I can add it to the todo list but not sure when I'll have time to do that. I'd obviously be happy to review a pull request that implements this feature too.

@petarminchev
Copy link
Contributor Author

@lminiero - Created a pull request - #3239. Seems to work for us, but of course you need to review it.

@lminiero
Copy link
Member

Thanks! I'll try to do it later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement multistream Related to Janus 1.x
Projects
None yet
Development

No branches or pull requests

2 participants