Support for batched configure requests in VideoRoom #2986
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
configure
request in the VideoRoom plugin can be used for different purposes, e.g., pausing/resuming streams, choosing simulcast layers, etc. So far, since we merged multistream, this was a drilldown request, meaning you had to specify themid
to act upon: this also meant that if you wanted to make multiple changes on different m-lines at the same time, you had to send differentconfigure
requests.This PR addresses that by adding a batched mode to
configure
instead, where you pass a stream calledarrays
with all the individual changes you want to make, e.g.:I've tested this briefly and it seems to work as expected, but of course more feedback would be helpful. Pinging @mirkobrankovic in particular as he expressed interested in something like this a few days ago.