Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for batched configure requests in VideoRoom #2986

Merged
merged 2 commits into from
Jun 1, 2022

Conversation

lminiero
Copy link
Member

The configure request in the VideoRoom plugin can be used for different purposes, e.g., pausing/resuming streams, choosing simulcast layers, etc. So far, since we merged multistream, this was a drilldown request, meaning you had to specify the mid to act upon: this also meant that if you wanted to make multiple changes on different m-lines at the same time, you had to send different configure requests.

This PR addresses that by adding a batched mode to configure instead, where you pass a stream called arrays with all the individual changes you want to make, e.g.:

subscription.send({message: {request: "configure", streams: [{mid: "0", send: true}, {mid: "1", send: true}]}})

I've tested this briefly and it seems to work as expected, but of course more feedback would be helpful. Pinging @mirkobrankovic in particular as he expressed interested in something like this a few days ago.

@lminiero lminiero added the multistream Related to Janus 1.x label May 25, 2022
@lminiero
Copy link
Member Author

lminiero commented Jun 1, 2022

Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multistream Related to Janus 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant