H264 profile fix #2212
Merged
H264 profile fix #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lminiero
reviewed
Jun 9, 2020
sdp-utils.c
Outdated
| if(check_profile) { | ||
| return pt; | ||
| } | ||
| else { |
There was a problem hiding this comment.
Code style nit: please put the else on the same line as the closing bracket.
sdp-utils.c
Outdated
| if(check_profile) { | ||
| return pt; | ||
| } | ||
| else { |
sdp-utils.c
Outdated
| if(check_profile) { | ||
| return pt; | ||
| } | ||
| else { |
|
Just tested this and it looks good to me! As soon as those small code style nits are addressed, I'll merge 👍 |
|
Ok done. |
|
Thanks, merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix janus_sdp_get_codec_pt_full so that it works when fmtp comes before rtpmap in the sdp, for vp9 and h264.