Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update janus.d.ts #2215

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Update janus.d.ts #2215

merged 1 commit into from
Jun 9, 2020

Conversation

Glandos
Copy link
Contributor

@Glandos Glandos commented Jun 9, 2020

Missing return types for attachMediaStream and reattachMediaStream

Sorry, I missed it in #2202 :/

Missing return types for `attachMediaStream` and `reattachMediaStream`
@lminiero
Copy link
Member

lminiero commented Jun 9, 2020

Sounds good, I never use those things anyway 🤭
As a side note, do you think those will need to be updated too, before we the multistream branch, considering there are changes to janus.js? (PR 2211)

@lminiero lminiero merged commit 90b9907 into meetecho:master Jun 9, 2020
@Glandos
Copy link
Contributor Author

Glandos commented Jun 9, 2020

Good question :)

However, given the fact that these types are hint for Typescript compilation, but not a blocker, you can safely merge #2211 first. And if someone like me need these types to be updated, well, it doesn't seem too much to do afterwards.

Moreover, it's good to wait for the API to stabilize. But if @lminiero has time to do it, it could be a good addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants