Multistream - Fixed lookup of participants in janus_vdeoroom.c if using string_ids #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lminiero
reviewed
Aug 6, 2020
plugins/janus_videoroom.c
Outdated
| guint64 feed_id = json_integer_value(feed); | ||
| janus_videoroom_publisher *publisher = g_hash_table_lookup(subscriber->room->participants, &feed_id); | ||
| guint64 feed_id; | ||
| char *feed_id_str; |
There was a problem hiding this comment.
Please initialize both variables, and remove the empty line here.
|
@lminiero I've updated the PR |
|
@ZeXtrasJay thanks! Apologies for the delay, but starting today I'm on vacation, so I'll be slow to answer for a few weeks. Merging. |
lminiero
pushed a commit
that referenced
this pull request
Sep 2, 2020
…2310) Co-authored-by: Davide Baldo <[email protected]>
lminiero
pushed a commit
that referenced
this pull request
Oct 30, 2020
…2310) Co-authored-by: Davide Baldo <[email protected]>
lminiero
pushed a commit
that referenced
this pull request
Dec 9, 2020
…2310) Co-authored-by: Davide Baldo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could not subscribe to streams using string_ids, it's only manually tested