Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: make audio/video recording in videocall working again #2325

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Bugfix: make audio/video recording in videocall working again #2325

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions plugins/janus_videocall.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1557,8 +1557,8 @@ static void *janus_videocall_handler(void *data) {
if(recording_base) {
/* Use the filename and path we have been provided */
g_snprintf(filename, 255, "%s-audio", recording_base);
session->arc = janus_recorder_create(NULL, janus_audiocodec_name(session->acodec), filename);
if(session->arc == NULL) {
rc = janus_recorder_create(NULL, janus_audiocodec_name(session->acodec), filename);
if(rc == NULL) {
/* FIXME We should notify the fact the recorder could not be created */
JANUS_LOG(LOG_ERR, "Couldn't open an audio recording file for this VideoCall user!\n");
}
Expand All @@ -1568,8 +1568,8 @@ static void *janus_videocall_handler(void *data) {
session->username ? session->username : "unknown",
(peer && peer->username) ? peer->username : "unknown",
now);
session->arc = janus_recorder_create(NULL, janus_audiocodec_name(session->acodec), filename);
if(session->arc == NULL) {
rc = janus_recorder_create(NULL, janus_audiocodec_name(session->acodec), filename);
if(rc == NULL) {
/* FIXME We should notify the fact the recorder could not be created */
JANUS_LOG(LOG_ERR, "Couldn't open an audio recording file for this VideoCall user!\n");
}
Expand All @@ -1586,8 +1586,8 @@ static void *janus_videocall_handler(void *data) {
if(recording_base) {
/* Use the filename and path we have been provided */
g_snprintf(filename, 255, "%s-video", recording_base);
session->vrc = janus_recorder_create(NULL, janus_videocodec_name(session->vcodec), filename);
if(session->vrc == NULL) {
rc = janus_recorder_create(NULL, janus_videocodec_name(session->vcodec), filename);
if(rc == NULL) {
/* FIXME We should notify the fact the recorder could not be created */
JANUS_LOG(LOG_ERR, "Couldn't open an video recording file for this VideoCall user!\n");
}
Expand All @@ -1597,8 +1597,8 @@ static void *janus_videocall_handler(void *data) {
session->username ? session->username : "unknown",
(peer && peer->username) ? peer->username : "unknown",
now);
session->vrc = janus_recorder_create(NULL, janus_videocodec_name(session->vcodec), filename);
if(session->vrc == NULL) {
rc = janus_recorder_create(NULL, janus_videocodec_name(session->vcodec), filename);
if(rc == NULL) {
/* FIXME We should notify the fact the recorder could not be created */
JANUS_LOG(LOG_ERR, "Couldn't open an video recording file for this VideoCall user!\n");
}
Expand Down