Insert disabled property for inactive m-line in streams for joined event #2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, thanks for the fix! Looks good to me, so I'll merge 👍 |
lminiero
pushed a commit
that referenced
this pull request
Oct 30, 2020
lminiero
pushed a commit
that referenced
this pull request
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an already streaming publisher removes one of its stream from handle, other participants will receive an update event with all publishers' active and inactive m-lines. Inactive m-lines will have a property called disabled with value true.
When a new publisher handle is attached to videoroom, this new handle will receive a joined event with all publishers' active and inactive m-lines. However for this event, inactive m-lines does not have a disabled property. This commit updates joined events to contain disabled property for inactive m-lines.