-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multistream] random port allocation for simulcast ports #2463
Conversation
Thanks for your contribution, @rahmanash-dbz! Please make sure you sign our CLA, as it's a required step before we can merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, added a couple of notes inline.
plugins/janus_streaming.c
Outdated
return NULL; | ||
} | ||
port3 = janus_streaming_get_fd_port(fd[2]); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation is all wrong. Please use tabs, not spaces, as that's our code style. No empty lines either.
plugins/janus_streaming.c
Outdated
JANUS_LOG(LOG_VERB, "We need a PLI for the simulcast context\n"); | ||
g_atomic_int_set(&stream->need_pli, 1); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
@rahmanash-dbz looks good, thanks! Please sign the CLA and we'll get this merged. |
Signed !, Thanks |
Thanks, merging 👍 |
This commit removes check where simulcast ports should be above zero for allocation. Also, included the need for PLI, independently of whether the substream is being relayed.