Fix hangup on inviting status after #2521

[AdrianoMartins]

The merge #2521 is causing a problem in the hangup of the call with status inviting, similar to the problem reported in #1856. I believe that the correct treatment for the situation of #2521, is to do with status different from destroyed.

[januscla]

Thanks for your contribution, @AdrianoMartins! Please make sure you sign our CLA, as it's a required step before we can merge this.

[lminiero]

Pinging @zayim as he contributed the patch you mentioned, so that you can both check if this fixes your requirements.

[zayim]

Hi! Sorry for late response.

I agree that merge #2521 broke hangup of inviting calls. But change you suggested just reverts my PR, since if you changed will always be true (due to lines 2528-2529).

I suggest adding additional check in if, so we send BYE/CANCEL only if session is established or status is inviting. In all other cases, we would send SIP response instead of BYE, which is correct behaviour.

Something like this: master...zayim:fix-sip-plugin-bye-on-inviting

I reproduced error on inviting calls on master, tested this code from my branch and verified that it fixes it.

[lminiero]

@zayim I think you moved it too much ahead, since it within the mutex lock now. I can't remember if there were risks of deadlocks there, but if the main purpose is doing something before the state changes, maybe it's simpler to move it before the janus_sip_call_update_status call?

[lminiero]

@AdrianoMartins ping 🙂

[zayim]

@lminiero I agree, this branch was in a rush just to test my theory. If Adriano agrees, I can edit by branch per your suggestion and make PR.

[lminiero]

@zayim sounds good to me, I'll wait for you guys to agree on which solution works best for you both.

[AdrianoMartins]

Sorry for the late response. @zayim I agree. Thanks.

[lminiero]

@AdrianoMartins thanks for the feedback!

[zayim]

Great, I will submit PR in next few hours.