Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ice: fix conncheck typo #2560

Merged
merged 1 commit into from
Feb 17, 2021
Merged

ice: fix conncheck typo #2560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ice.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,16 +124,16 @@ const char *janus_ice_get_nomination_mode(void) {
#endif

/* Keepalive via connectivity checks */
static gboolean janus_ice_keepalive_connckecks = FALSE;
static gboolean janus_ice_keepalive_connchecks = FALSE;
void janus_ice_set_keepalive_conncheck_enabled(gboolean enabled) {
janus_ice_keepalive_connckecks = enabled;
if(janus_ice_keepalive_connckecks) {
janus_ice_keepalive_connchecks = enabled;
if(janus_ice_keepalive_connchecks) {
JANUS_LOG(LOG_INFO, "Using connectivity checks as PeerConnection keep-alives\n");
JANUS_LOG(LOG_WARN, "Notice that the current libnice master is breaking connections after 50s when keepalive-conncheck enabled. As such, better to stick to 0.1.18 until the issue is addressed upstream\n");
}
}
gboolean janus_ice_is_keepalive_conncheck_enabled(void) {
return janus_ice_keepalive_connckecks;
return janus_ice_keepalive_connchecks;
}

/* Opaque IDs set by applications are by default only passed to event handlers
Expand Down Expand Up @@ -3499,7 +3499,7 @@ int janus_ice_setup_local(janus_ice_handle *handle, int offer, int audio, int vi
#ifdef HAVE_ICE_NOMINATION
"nomination-mode", janus_ice_nomination,
#endif
"keepalive-conncheck", janus_ice_keepalive_connckecks ? TRUE : FALSE,
"keepalive-conncheck", janus_ice_keepalive_connchecks ? TRUE : FALSE,
#ifdef HAVE_LIBNICE_TCP
"ice-udp", TRUE,
"ice-tcp", janus_ice_tcp_enabled ? TRUE : FALSE,
Expand Down