Fix SIP plugin missed_call event call_id field name typo #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fair point, it looks like the name of the property was changed in #2679 (my fault for not catching that). Mentioning @nicolasduteil who authored the PR, and so may need to be aware the property name is being changed (in case he uses it somewhere). |
|
Yep, my mistake. Sorry about that |
|
No worries! Just wanted you to be aware of the new change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all events except
missed_callusedcall_idfield name for SIP Call-ID. And even docs ofmissed_callpointscall_idfield name. Socallidseems to be a typo here.