SIP plugin: Fix sending BYE #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feels like deja-vù: haven't we discussed this already in the past? IIRC there were a couple of "conflicting" PRs that tried to address the same thing in different ways. |
|
It may be #2554. |
|
#2554 addressed the issue when the session is destroyed in "sip inviting" status. This one is fixing the issue when the SIP call is established by SIP protocol (INVITE sent and 200 OK received or INVITE received and 200 OK sent), but the webrtc side is not. In this case, SIP BYE should be sent too. |
|
Makes sense 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that we sometimes receive the following error from sofia sip when the call should be terminated.
[nua_i_error]: 500 Responding to a Non-Existing RequestAfter further investigation, I found out that this is happening when ICE or DTLS negotiation fails. The problem was in this condition if BYE or 480 should be sent. It should use method
janus_sip_call_is_establishedbecausesession->establishedis set toTRUEonly when ICE and DTLS negotiation finish.I already tested this and it's working fine but the feedback is welcome.