Better SRTP-SDES negotiation in SIP/NoSIP plugins (fixes #2726) #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Becuase of some broken dependencies on our OS we cannot deploy the new code yet. I will get back once we can do these tests at a later moment. Many thanks! |
|
@adigeo any update? Otherwise I'll just merge as it is, and we'll revisit later if needed. |
|
Because of vacation we cannot do it right now, please feel free to push it and we will test it later (in August) |
|
Ack, thanks for the heads up! Merging then 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our SRTP-SDES negotiation in the SIP and NoSIP plugins was quite crappy, with some hardcoded values and a few missing checks on whether we supported profiles at all. This patch should improve this, and hopefully fix the issue described in #2726. Please test.