add streams info and publisher display to publish event sent to event handlers (videoroom) #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution, @aberrios1! Please make sure you sign our CLA, as it's a required step before we can merge this. |
aberrios1
changed the title
|
Sorry for the late response @aberrios1 and thanks for your first contribution! I'll have a look later today and post a review. |
lminiero
reviewed
Sep 27, 2021
| if(ps->svc) | ||
| json_object_set_new(mediainfo, "svc", json_true()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Ah nevermind, this is similar to how we advertise streams to subscribers anyway: datachannels are notified as part of the type, and need no extra info as audio and video do instead.
|
Looks good to me, thanks, merging! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much my first open source contribution anywhere, be nice 😄
Added info about streams published on publish event sent to event handlers.
Wanted to get the stream descriptions in our publish events.
Let me know if this is useful or not, or if something needs changing.