Initial support for DTX (EchoTest, VideoRoom) #2789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small patch to make EchoTest and VideoRoom aware of DTX in negotiation, so that it can be enabled in case. Not tested extensively yet, which will need to be done to see if there can be an impact on recordings or audio quality in rooms. Since this patch mostly touched the SDP negotiation those plugins do, I took advantage of this to also change something else, e.g., allow the VideoRoom to negotiate stereo on subscribers if the publisher offers it.
Feedback welcome!