Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix saving signed_tokens field when room is permanent #2843

Merged
merged 1 commit into from
Jan 10, 2022
Merged

fix saving signed_tokens field when room is permanent #2843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions plugins/janus_videoroom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3445,6 +3445,8 @@ static json_t *janus_videoroom_process_synchronous_request(janus_videoroom_sessi
janus_config_add(config, c, janus_config_item_create("is_private", "yes"));
if(videoroom->require_pvtid)
janus_config_add(config, c, janus_config_item_create("require_pvtid", "yes"));
if(videoroom->signed_tokens)
janus_config_add(config, c, janus_config_item_create("signed_tokens", "yes"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in the "edit" part too? Even if "edit" doesn't expose a way to modify that property, if you don't have lines to save the value there, a permanent "edit" will result in not saving the signed_tokens property, which would be lost as a consequence.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh, you're right. I forgot about edit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lminiero done

if(videoroom->require_e2ee)
janus_config_add(config, c, janus_config_item_create("require_e2ee", "yes"));
g_snprintf(value, BUFSIZ, "%"SCNu32, videoroom->bitrate);
Expand Down Expand Up @@ -3629,6 +3631,8 @@ static json_t *janus_videoroom_process_synchronous_request(janus_videoroom_sessi
janus_config_add(config, c, janus_config_item_create("is_private", "yes"));
if(videoroom->require_pvtid)
janus_config_add(config, c, janus_config_item_create("require_pvtid", "yes"));
if(videoroom->signed_tokens)
janus_config_add(config, c, janus_config_item_create("signed_tokens", "yes"));
if(videoroom->require_e2ee)
janus_config_add(config, c, janus_config_item_create("require_e2ee", "yes"));
g_snprintf(value, BUFSIZ, "%"SCNu32, videoroom->bitrate);
Expand Down