Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same version number for npm package #2901

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

siebertm
Copy link
Contributor

I noticed that the package.json still includes version 0.7.5, while the main repo is at 0.11.8 right now. I feel those should be matching? (I may be wrong, but there's only one way to find out!)

@januscla
Copy link

Thanks for your contribution, @siebertm! Please make sure you sign our CLA, as it's a required step before we can merge this.

@lminiero
Copy link
Member

Good catch: while I usually update several files every time we do a release, I don't think we ever updated that one (probably because I even forgot it exists: I most definitely never use that file).

That said, the version number you committed is incorrect: master is 1.0.0 now. The 0.11.8 version should be put on the 0.x branch, where the previous version of Janus lives on.

@siebertm
Copy link
Contributor Author

Thanks for the quick feedback! I am a strong believer of Changelog files and tags, and both state 0.11.8 on master... Where's the "real" version number noted?

@lminiero
Copy link
Member

The changelog is only updated when we freeze a release. Master is version 1.0.0:

https://github.com/meetecho/janus-gateway/blob/master/configure.ac#L1
https://groups.google.com/g/meetecho-janus/c/t181VvXl0Es/m/qgBkfo77BQAJ

@lminiero
Copy link
Member

As a side note, 0.x is currently 0.12.0, which will be the next version we'll tag for the 0.x branch.
https://github.com/meetecho/janus-gateway/blob/0.x/configure.ac#L1

As such, the package.json for that will be 0.12.0.

@siebertm
Copy link
Contributor Author

Alright, noted! Also, the version number is updated!

@lminiero
Copy link
Member

Ack, thanks! I'll merge then, and update 0.x accordingly.

@lminiero lminiero merged commit 2009325 into meetecho:master Feb 24, 2022
lminiero added a commit that referenced this pull request Feb 24, 2022
@siebertm
Copy link
Contributor Author

Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants