increased sip buffer size

[kenangenjac]

In the last few days we have been getting a lot of spam logs from Janus on our WebRTC platform.
The log messages looks like this: Truncation occurred, 2132 >= 2048, and are usually caused by destination buffer being close to the size of the sofia_log array max size , which is set to 2048 inside janus_sip.c file.

The truncation occurs by invoking janus_strlcat function on the 1744th and 1757th line inside janus_sip_sofia_logger function, located in janus_sip.c. When the janus_strlcat is invoked, destination buffer, source buffer and destination size in bytes are concatenated and truncation occurs.

In this PR I made a change to the sofia_log array, making it 3kB, instead of the original 2kB, as I saw that the return value of the janus_strlcat, which causes the overflow and truncation, is never more than 2.3kB.

[januscla]

Thanks for your contribution, @kenangenjac! Please make sure you sign our CLA, as it's a required step before we can merge this.

[lminiero]

That variable is only needed when using event handlers with the SIP plugin: is this what you're doing? If so, have you checked if you're also impacted by #3031, and if the diff attached in one of the comment helps?

[kenangenjac]

We aren't using the event handlers, but we fear we might miss something important due to this message spamming our logs, which is why we proposed this buffer increase.

[lminiero]

You're not missing anything, if you're not using event handlers. That said, the patch may still be useful for those that do.

[kenangenjac]

Yes, I think it would possibly be useful for others as it could be a general issue. With that in mind, if the PR is not going to be accepted and is not for merging, could You please close it.

[lminiero]

No need, I'll merge, and backport to 0.x. Thanks!

[kenangenjac]

Great! Thank You, glad I contributed!