Close mountpoint sockets when leaving relay thread (fixes #3111) #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoppi
reviewed
Jan 10, 2023
Comment on lines
+9323
to
+9331
| if(stream->fd[0] > -1) | ||
| close(stream->fd[0]); | ||
| stream->fd[0] = -1; | ||
| if(stream->fd[1] > -1) | ||
| close(stream->fd[1]); | ||
| stream->fd[1] = -1; | ||
| if(stream->fd[2] > -1) | ||
| close(stream->fd[2]); | ||
| stream->fd[2] = -1; |
There was a problem hiding this comment.
This looks a bit redundant, why not use a simple loop?
for(int i=0; i<3; i++) {
if(stream->fd[i] > -1) {
close(stream->fd[i]);
stream->fd[i] = -1;
}
}There was a problem hiding this comment.
Since i was small enough and known, it felt easier to do that. Besides, I just copied what we had in the _free callback already.
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes the sockets used by a mountpoint when leaving the related thread: since a "destroy" request joins the thread, this ensures ports are free once a response is sent. Before, sockets would only be closed in the mountpoint free callback, so when reference counters gave the green light, which could take longer and cause the issue described in #3111.