Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of external css and js resources #3279

Closed
wants to merge 1 commit into from

Conversation

bkmgit
Copy link
Contributor

@bkmgit bkmgit commented Oct 15, 2023

No description provided.

@lminiero
Copy link
Member

Sorry for the late feedback. This PR is not only updating the versions, it's changing the source of those JS files as well, which I personally don't like and don't want to go through. Any reason why you did that?

@bkmgit
Copy link
Contributor Author

bkmgit commented Oct 27, 2023 via email

@lminiero
Copy link
Member

lminiero commented Nov 4, 2023

If updating version is ok, can change source back to what it was.

For the time being I'd prefer that, yes. The change of source is something that can be discussed in a separate PR.

That said, I'm not sure how safe updating jQuery is, especially when building the documentation, as I don't know if there's things Doxygen relies upon that may be affected by breaking changes.

You're also updating the version of Bootstrap to 5.x, which is wrong. Bootstrap 5 is completely incompatible with the templates we use, which uses Bootstrap 3. A few times I've tried working on upgrading our demos to Bootstrap 4 or 5, and always failed miserably, because there's too much to change and I always got stuck in some places.

Please make sure to only submit commits that upgrade versions that you've explicitly tested yourself, for all demos.

@lminiero
Copy link
Member

@bkmgit any update on this? Thanks!

@bkmgit
Copy link
Contributor Author

bkmgit commented Nov 16, 2023

Thanks for your comments. Sorry for the delay. Will check with a deployment.

@bkmgit
Copy link
Contributor Author

bkmgit commented Nov 26, 2023

Yes you are correct, documentation does not build and pages do not render correctly.

@bkmgit
Copy link
Contributor Author

bkmgit commented Nov 27, 2023

Closing in favor of #3295

@bkmgit bkmgit closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants