-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all demo pages to a demos/ subfolder #3302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change https://github.com/meetecho/janus-gateway/pull/3302/files#diff-0462e381b2fb3286568215681c8983490a37ac9ae0f0c5ee304df7fa6426d4afR24 to
demosdir = $(datadir)/janus/
so that installed demos are in $(datadir)/janus/demos
and not $(datadir)/janus/demos/demos
That wouldn't work, because it would put all html files nt in |
That seems ok, thanks. |
After updating demos and docs to use Bootstrap 5.x in #3300, I reorganized the
html
folder a bit, by moving all demos to ademos
subfolder: the purpose was to cleanup the web folder a bit, like when we moved all the code tosrc
.As part of this restructuring, I also renamed most of the demo pages too: many of them still had a
test
in it that was unneeded, so I got rid of it. Besides, I added a link to the related plugin's documentation on top of every demo: this will hopefully make people more aware of which plugin is powering each demo, and convince them to checkout the related docs (which not everyone does, unfortunately) if they want to learn more.