Move all demo pages to a demos/ subfolder #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lminiero
changed the title
bkmgit
reviewed
Dec 18, 2023
There was a problem hiding this comment.
Maybe change https://github.com/meetecho/janus-gateway/pull/3302/files#diff-0462e381b2fb3286568215681c8983490a37ac9ae0f0c5ee304df7fa6426d4afR24 to
demosdir = $(datadir)/janus/
so that installed demos are in $(datadir)/janus/demos and not $(datadir)/janus/demos/demos
|
That wouldn't work, because it would put all html files nt in |
|
That seems ok, thanks. |
lminiero
added a commit
that referenced
this pull request
Jan 15, 2024
Rabenherz112
added a commit
to Rabenherz112/awesome-selfhosted-data
that referenced
this pull request
Jan 16, 2024
nodiscc
pushed a commit
to awesome-selfhosted/awesome-selfhosted-data
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating demos and docs to use Bootstrap 5.x in #3300, I reorganized the
htmlfolder a bit, by moving all demos to ademossubfolder: the purpose was to cleanup the web folder a bit, like when we moved all the code tosrc.As part of this restructuring, I also renamed most of the demo pages too: many of them still had a
testin it that was unneeded, so I got rid of it. Besides, I added a link to the related plugin's documentation on top of every demo: this will hopefully make people more aware of which plugin is powering each demo, and convince them to checkout the related docs (which not everyone does, unfortunately) if they want to learn more.