Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for hjson #230

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Remove support for hjson #230

merged 1 commit into from
Oct 12, 2021

Conversation

matthiasbeyer
Copy link
Collaborator

The serde-hjson crate is not maintained anymore and this feature is
actually causing pain in packaging even.

Thus, remove it.

Closes #198

@matthiasbeyer
Copy link
Collaborator Author

matthiasbeyer commented Sep 26, 2021 •
edited
Loading

@dlo9 you wrote the line that fails clippy here. Am I just stumbling on a bug because this field is not used anywhere?

Possibly same for the other lines...

@dlo9
Copy link
Contributor

dlo9 commented Sep 28, 2021

@matthiasbeyer My change on those lines was just changing HashMap to the new Map type alias, there was no substantial change to those fields. Nightly clippy fails with the same errors when run on the commit prior to my PR.

AFAICT these are new checks that nightly clippy added recently, and which are completely valid, but just haven't previously been run on this codebase. Most of these are because #207 added the AsyncConfigBuilder but doesn't have an impl for it, so its fields aren't used anywhere.

@matthiasbeyer
Remove support for hjson
7485f27 
The serde-hjson crate is not maintained anymore and this feature is
actually causing pain in packaging even.

Thus, remove it.

Signed-off-by: Matthias Beyer <[email protected]>
@matthiasbeyer matthiasbeyer added the hacktoberfest-accepted Accepted PR for hacktoberfest label Oct 12, 2021
@matthiasbeyer
Copy link
Collaborator Author

I guess I'll merge this then, the fixes for the clippy warnings should go into a seperate PR anyways.

@matthiasbeyer matthiasbeyer merged commit a98ddad into mehcode:master Oct 12, 2021
@matthiasbeyer matthiasbeyer deleted the drop-hjson branch October 12, 2021 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted PR for hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please consider switching upstream implementations to reduce repetitive dependencies
2 participants
@matthiasbeyer @dlo9