-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: env contains list of strings #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise this looks good, but please fix the commit message and use a real signoff line! 😃
4ec2bd6
to
5357c67
Compare
Ups. 😄 Done. |
I noticed, that with my first implementation one have to decide what to use. Strings or lists of strings. So i added an option which allows adding the keys of environment variables to be listed for parsing. |
Any chance we get this merged? |
@matthiasbeyer Hi, can we merge this now? checks are green and branch is up to date. |
Yeah I think so. Please rebase the branch so the merge commits vanish! 👍 |
Signed-off-by: simon-an <[email protected]>
9e75d32
to
53322d4
Compare
Signed-off-by: simon-an [email protected]
fixes #117