Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prefix separator #292

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

conradludgate
Copy link
Contributor

Should fix #291

@conradludgate conradludgate force-pushed the 291-prefix-separator branch 3 times, most recently from f509ab2 to d40ff1d Compare February 24, 2022 10:08
Copy link
Collaborator

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome that you provided a patch right away!

Lets see what CI tells us.

@conradludgate
Copy link
Contributor Author

conradludgate commented Feb 24, 2022

🤦 that clippy warning is annoying. My editor told me to do exactly the opposite 😅.

I'll fall back to a regular match, because no matter how I mix/match or/or_else either stable clippy or beta clippy will complain

@matthiasbeyer matthiasbeyer merged commit 92e29a3 into mehcode:master Feb 24, 2022
@conradludgate conradludgate mentioned this pull request Mar 2, 2022
@jrconlin
Copy link

jrconlin commented Apr 3, 2022

Hi. Unfortunately, this bug impacts our code update. Is there any chance you could tag a new release with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in nested environment paths
3 participants