302-add-set-override-option-combinator #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasbeyer
requested changes
Mar 19, 2022
matthiasbeyer
requested changes
Mar 21, 2022
|
Besides the one comment this looks good, feel free to squash (including the change for the comment from above)! |
saraiva132
force-pushed
the
302-add-set-override-option
branch
from
7a80d34
to
1195795
Compare
|
I failed my squash miserably, can you squash for me on merge ? :) 🙇 |
matthiasbeyer
force-pushed
the
302-add-set-override-option
branch
from
1195795
to
da3e483
Compare
|
Not on merge, because squash merging is bad. I rebased for you and pushed to your PR branch. |
|
The CI failure comes from something else, which I fix in #304 - I wil rebase this PR for you after that other fix is merged! |
This patch adds ConfigBuilder::set_override_option() to override a setting from an Option<_>. Signed-off-by: Matthias Beyer <[email protected]>
matthiasbeyer
force-pushed
the
302-add-set-override-option
branch
from
da3e483
to
be7afe9
Compare
matthiasbeyer
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in #302.
@matthiasbeyer I checked
Environmentand I do not believe it is not designed to support loading single env vars. This is just an example of how the method could look like.