-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MSRV: 1.66.0 -> 1.70.0 #483
Conversation
Signed-off-by: Matthias Beyer <[email protected]>
b84b5cb
to
81ac1a2
Compare
I think this is overly high. In the Arti project we are using Perhaps the problem is testing with too-new versions of dependencies? In |
Having said that, I don't think there is any problem with you changing the documentation to say you don't support earlier than 1.70. That doesn't stop us using it with 1.65, and it works for us there. But please don't add a |
You need to consider that this is for the next release, which (as far as I would say) isn't due to in the next few days, but rather maybe at the end of the year (read: after two more rust versions). So right now this means we're working on the last three rust versions, but when the next version of this crate is published, it is more like the last five rust versions! |
It's not my intention to do so 😆 |
If you like, I could try making an MR that changes the MSRV test: IMO it should downgrade the dependencies and test with 1.66 (or 1.65 or even earlier - I bet your docs are overly conservative). |
(but you should probably merge this first to unblock all the stuck MRs) |
Please correct me if I am wrong @ijackson - this is okay with you now, isn't it? Because it only affects the next minor version, not the patch release we're planing for the 0.13.x branch of things, right? |
It's OK either way. |
I did though 😅 #478
@ijackson is the concern due to dependencies incorrectly setting a I know that |
No description provided.