support ini #72
Merged
support ini #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodgear
force-pushed
the
feature/ini
branch
3 times, most recently
from
5528045
to
ba60145
Compare
added 2 commits
June 15, 2018 11:13
Closed
vorner
reviewed
Jun 24, 2018
Cargo.toml
Outdated
| @@ -28,6 +30,7 @@ toml = { version = "^0.4.1", optional = true } | |||
| serde_json = { version = "^1.0.2", optional = true } | |||
| yaml-rust = { version = "^0.4", optional = true } | |||
| serde-hjson = { version = "^0.8.1", optional = true } | |||
| rust-ini = "0.12.1" | |||
There was a problem hiding this comment.
Is there a reason not to make this one optional too?
vorner
reviewed
Jun 24, 2018
src/file/format/mod.rs
Outdated
| @@ -36,6 +39,10 @@ pub enum FileFormat { | |||
| /// HJSON (parsed with serde_hjson) | |||
| #[cfg(feature = "hjson")] | |||
| Hjson, | |||
| /// INI (parsed with serde_hjson) | |||
|
Thanks for the changes… anyway, I was just walking by and noticed few things, it wasn't a real review (and I'm not in any way related to the project anyway) ‒ so someone from the project will have to have a look too 😇 |
|
:-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.