-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support ini #72
support ini #72
Conversation
5528045
to
ba60145
Compare
Cargo.toml
Outdated
@@ -28,6 +30,7 @@ toml = { version = "^0.4.1", optional = true } | |||
serde_json = { version = "^1.0.2", optional = true } | |||
yaml-rust = { version = "^0.4", optional = true } | |||
serde-hjson = { version = "^0.8.1", optional = true } | |||
rust-ini = "0.12.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason not to make this one optional too?
src/file/format/mod.rs
Outdated
@@ -36,6 +39,10 @@ pub enum FileFormat { | |||
/// HJSON (parsed with serde_hjson) | |||
#[cfg(feature = "hjson")] | |||
Hjson, | |||
/// INI (parsed with serde_hjson) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy-pasted comment?
Thanks for the changes… anyway, I was just walking by and noticed few things, it wasn't a real review (and I'm not in any way related to the project anyway) ‒ so someone from the project will have to have a look too 😇 |
:-D |
No description provided.