support reading enums from config #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geniusisme
commented
Nov 10, 2018
| } | ||
| } | ||
|
|
||
| impl<'de> de::VariantAccess<'de> for EnumAccess { |
There was a problem hiding this comment.
Regarding panics in this impl:
- We already checked size of map, and one only can have VariantAcces from EnumAccess, which performs the check.
- If visitor chooses wrong variant to visit, leading to unreachable!(), then it is a buggy visitor, this is not a failure one can/should recover from.
|
I guess we need to upgrade to serde-hjson v0.8.2 and update error check. Can do in this pull request. |
|
Looks great. Thanks for this. Sorry for the delay in merging this. I'd love the update to hjson when you get time. |
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #74.