-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming some variables #58
Comments
Why are we removing the I sort of like how it works now because it keeps the config to a minimum (don't have to define the primary key in config) and also doesn't require running two http requests for every search (to figure out the primary key). It would be cool to override the I just updated the
|
69: Rename indexName to indexUid r=curquiza a=codedge This PR renames the `indexName` variables to `indexUid`, see #58. Co-authored-by: Holger Lösken <[email protected]>
70: Rename requestOptions to searchParams r=curquiza a=codedge This PR renames the `requestOptions` variable to `searchParams`, see #58. Co-authored-by: Holger Lösken <[email protected]> Co-authored-by: Holger Lösken <[email protected]>
I let this issue opened since there is still some |
Yes, for the |
This package was strongly based on the Algolia Symfony Bundler (https://github.com/algolia/search-bundle/ - MIT License).
MeiliSearch and Algolia are indeed similar but not exactly the same. It means there are some naming inconsistencies in the code base of this repository.
objectId
should not be used. MeiliSearch does not generate anyobjectId
but contains aprimaryKey
that depends on the user dataset. See an example of how to fetch the current primary key of an index💡 More about the primary key
requestOptions
should be renamed intosearchParams
(done with Rename requestOptions to searchParams #70)indexName
should be renamed asindexUid
(done with Rename indexName to indexUid #69)I would rather each point be done in different PRs 🙂
Feel free to ask any question you need!
The text was updated successfully, but these errors were encountered: