Add multi search

[norkunas]

Pull Request

Related issue

Fixes #246

What does this PR do?

• Add's multi search method

PR checklist

Please check if your PR fulfills the following requirements:

• Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
• Have you read the contributing guidelines?
• Have you made sure that the title is accurate and descriptive of the changes?

Opening this PR to discuss the implementation, because not sure what are the expectations, so not ready to merge :)

[brunoocasali]

This seems to be a common thing in the bundle, no? I'm wondering if this could be reused somewhere else.

[norkunas]

Yes, but I'd leave that for later :)

[norkunas]

@brunoocasali I'm not sure if we should have a totally separate SearchQuery that is converted to the client one or extend it.. which one you prefer? I chose former one because I thought there is not point to have a setIndexUid method, but then we must duplicate everything.

[brunoocasali]

Why you don't think the setIndexUid is not useful for the multi-search? From what I saw in the code you're going to send a multi-search for all the configured indices right?

If yes, I'm not sure it is the right approach... Since I could have a lot of defined models but want to search in a subset, in this case I would have a lot of useless data being sent over the network.

[norkunas]

Why you don't think the setIndexUid is not useful for the multi-search?

That's because in bundle we operate on the class level, so you instantiate a SearchQuery with for example test fixture Post::class which will be later then converted to the real index name test_posts etc.
But sure, if you have the full index name at hand, maybe it could be useful 🤔

I followed the same approach as for the single index search $this->searchService->search($this->entityManager, Post::class, 'term')

[brunoocasali]

Oh, okay I see it now!

[brunoocasali]

Just a comment + fixing the styling, and we're good to go!

[brunoocasali]

👀

[norkunas]

Just a comment + fixing the styling, and we're good to go!

aggregator support needs to be added I think also, but first I need to understand it how to make it work :)

[brunoocasali]

👍 LGTM!

[SirMishaa]

Any up for this ? Really looking for it, would be really useful 👀

What's failing in the C.I ?

[SirMishaa]

Suggested change

	// $response = $this->engine->multiSearch(array_map(function (SearchQuery $query) use ($prefix, $indices) {
	// $this->assertIsSearchable($query->getClassName());
	//
	// return $query->toEngineQuery($prefix, $indices);
	// }, $queries));

[norkunas]

@brunoocasali do you have any suggestions how to make this work with aggregators?

For example if you define Post index and then an aggregator that is also uses Post then there is an ambiguity where to search.
Do we need to return for both indexes? What if I want to really only search in Post index and avoid searching in aggregated index?

[brunoocasali]

For example if you define Post index and then an aggregator that is also uses Post then there is an ambiguity where to search.

Can you remind me about what the "aggregators" should do in the first place? Is it the ability to map two models into the same index?

Because in any case, I think we could release without that and figure out that later, WDYT?

[norkunas]

Can you remind me about what the "aggregators" should do in the first place? Is it the ability to map two models into the same index?

I think so..

Because in any case, I think we could release without that and figure out that later, WDYT?

Okay maybe :) also I think it's possible to define same class as multiple indexes,so there would be same problem that it would search also in all of those 🤔

[brunoocasali]

Okay maybe :) also I think it's possible to define same class as multiple indexes,so there would be same problem that it would search also in all of those 🤔

Do you mean, even without this PR? Because I think this could be a problem indeed, so we would not need to worry about that possibility here, right?

[brunoocasali]

I think if you feel the code for the feature is good enough you can push forward and then grab some user feedback about the feature, WDYT?

I also encouraged the rails maintainer to do a similar approach, instead of waiting to have the best public API in town 😅.

[norkunas]

Yeah ok,just need to find some time to finish it:)

[czachor]

Hi, do you need help here? Maybe I'll be able to do something. Multisearch is an important functionality for me :)

[norkunas]

Hi, if you want to continue the work of this then go ahead.

[mrmadhat]

What is the work required? Is it to remove the unnecessary comment and add getters to fix the code style issues?

[norkunas]

To decide properly how it should behave :)