Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible HTML escaping-type issue? #587

Closed
5 tasks done
Nantris opened this issue Oct 7, 2022 · 3 comments
Closed
5 tasks done

Possible HTML escaping-type issue? #587

Nantris opened this issue Oct 7, 2022 · 3 comments
Labels
bug:upstream The bug is caused by a third party library.

Comments

@Nantris
Copy link

Nantris commented Oct 7, 2022

Decision Table

  • My issue does not look like “The HTML attribute 'xxx' is ignored” (unless we claim support for it)
  • My issue does not look like “The HTML element <yyy> is not rendered”

Good Faith Declaration

Description

Pasting in some HTML which contains a codeblock which contains the JS code for our tagStyles, I noticed that changing the font size set to 10 for code elements was not applying evenly:

image

React Native Information

expo-env-info 1.0.5 environment info:
    System:
      OS: Linux 5.15 Ubuntu 22.04.1 LTS 22.04.1 LTS (Jammy Jellyfish)
      Shell: 5.8.1 - /usr/bin/zsh
    Binaries:
      Node: 16.17.0 - ~/.nvm/versions/node/v16.17.0/bin/node
      Yarn: 1.22.19 - ~/.nvm/versions/node/v16.17.0/bin/yarn
      npm: 8.15.0 - ~/.nvm/versions/node/v16.17.0/bin/npm
      Watchman: 4.9.0 - /usr/bin/watchman
    SDKs:
      Android SDK:
        API Levels: 31, 32, 33
        Build Tools: 30.0.3, 31.0.0, 33.0.0
        System Images: android-31 | Google APIs Intel x86 Atom_64, android-31 | Google Play Intel x86 Atom_64
    npmPackages:
      react: ~18.0.0 => 18.0.0 
      react-dom: ~18.0.0 => 18.0.0 
    npmGlobalPackages:
      eas-cli: 2.1.0
      expo-cli: 6.0.5
    Expo Workflow: managed

PS: It's no longer expo diagnostics but rather npx expo-env-info



### RNRH Version

6.3.4

### Tested Platforms

- [X] Android
- [ ] iOS
- [ ] Web
- [ ] MacOS
- [ ] Windows

### Reproduction Platforms

- [X] Android
- [ ] iOS
- [ ] Web
- [ ] MacOS
- [ ] Windows

### Minimal, Reproducible Example

**The HTML that seems to have caused this is as below:**

Redacted

### Additional Notes

_No response_
@Nantris Nantris added the bug Crush'em all. label Oct 7, 2022
@jsamr
Copy link
Collaborator

jsamr commented Oct 7, 2022

@slapbox It looks very much like this is a specific and annoying React Native bug: facebook/react-native#31826 If this issue does not happen on Web/iOS, it would reinforce this hypothesis. Without reproduction I can't confirm though.

Edit: this bug might have been fixed in Fabric; check if it's enabled in your setup. https://reactnative.dev/docs/new-architecture-app-renderer-android

@jsamr jsamr added bug:upstream The bug is caused by a third party library. and removed bug Crush'em all. labels Oct 7, 2022
@jsamr jsamr closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2022
@Nantris
Copy link
Author

Nantris commented Oct 9, 2022

Hmm.. Weird bug! Thanks for your reply @jsamr.

My initial impression was that this is the issue, but now I'm not so sure. Unfortunately the element inspector won't respond when I click on the block of text that demonstrates the problem.

I'm currently trying to test this on iOS but need to wait on most of an hour of dependency installs/building.

@Nantris
Copy link
Author

Nantris commented Oct 9, 2022

Confirmed; not present on iOS, so I assume it's the issue you linked. Thanks again @jsamr for your great work and support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:upstream The bug is caused by a third party library.
Projects
None yet
Development

No branches or pull requests

2 participants