Skip to content
This repository has been archived by the owner on Jun 11, 2019. It is now read-only.

Race condition with aws sdk causes invalid output on occasion. #16

Closed
potatolain opened this issue Jan 27, 2017 · 2 comments
Closed

Race condition with aws sdk causes invalid output on occasion. #16

potatolain opened this issue Jan 27, 2017 · 2 comments

Comments

@potatolain
Copy link

While generating secrets for a terraform repository, one of my secrets failed to work with no further output. On looking into the txt file i had secretary print out to (Using stdout redirection, and no stderr redirection) also had the following error:

2017/01/24 11:10:56 Request body type has been overwritten. May cause race conditions

I believe this is the issue described in this AWS go sdk ticket: aws/aws-sdk-go#868 - so the solution may be as simple as updating to a newer version of that library. (That ticket is resolved in a build from October - looks like what we have is from September.)

I haven't worked in Go before, or I might have just submitted a PR - hopefully this is pretty straightforward to fix though.

mikljohansson pushed a commit that referenced this issue Jan 30, 2017
jcsorvasi added a commit that referenced this issue Jan 30, 2017
@mikljohansson
Copy link
Contributor

@cppchriscpp would you mind checking if the newly minted Secretary version 0.9.1 resolve your problem?

@potatolain
Copy link
Author

I tried encrypting a few things and didn't run into the issue again. The issue was intermittent, so I guess I can't know for sure, but it certainly seems to be fixed.

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants