Skip to content
This repository has been archived by the owner on Jun 11, 2019. It is now read-only.

Avoid need for workarounds for $AWS_DEFAULT_REGION #14

Merged
merged 2 commits into from
Oct 3, 2016

Conversation

mikljohansson
Copy link
Contributor

@mikljohansson mikljohansson commented Sep 30, 2016

The awsudo and awscli tools sets $AWS_DEFAULT_REGION instead of $AWS_REGION as the AWS Golang SDK expected. To use secretary together with awsudo some workarounds are needed, like running a bash subshell and explicitly overriding $AWS_REGION.

  • Updated to latest release of AWS golang SDK which supports "Shared Config" (e.g. ~/.aws/config)
  • Force enable Shared Config which enables the SDK to read $AWS_DEFAULT_REGION
  • Use EC2 meta-data service to autodetect current AWS region if needed (only works inside EC2)

@codecov-io
Copy link

codecov-io commented Sep 30, 2016

Current coverage is 52.17% (diff: 0.00%)

Merging #14 into master will decrease coverage by 3.04%

@@             master        #14   diff @@
==========================================
  Files             8          8          
  Lines           565        598    +33   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            312        312          
- Misses          213        246    +33   
  Partials         40         40          

Powered by Codecov. Last update c687921...2d5cc14

@rasjoh rasjoh merged commit 8f71387 into master Oct 3, 2016
@rasjoh rasjoh deleted the support-shared-config branch October 3, 2016 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants