Skip to content
This repository has been archived by the owner on Jun 11, 2019. It is now read-only.

Check that envvars are valid identifiers when using encrypted strings #8

Merged
merged 1 commit into from
Feb 19, 2016

Conversation

mikljohansson
Copy link
Contributor

When Secretary decrypts something it outputs a scriptlet that is sourced into the env, to overwrite encrypted env vars with decrypted ones. Meaning that env vars with encrypted substrings like rabbitmq.password won't work since they contain dots. This change ensures the problem is caught with a user readable error

@codecov-io
Copy link

Current coverage is 55.36%

Merging #8 into master will increase coverage by +0.92% as of 57ead2f

@@            master      #8   diff @@
======================================
  Files            8       8       
  Stmts          461     466     +5
  Branches        70      70       
  Methods          0       0       
======================================
+ Hit            251     258     +7
+ Partial         31      30     -1
+ Missed         179     178     -1

Review entire Coverage Diff as of 57ead2f

Powered by Codecov. Updated on successful CI builds.

alexandernilsson added a commit that referenced this pull request Feb 19, 2016
Check that envvars are valid identifiers when using encrypted strings
@alexandernilsson alexandernilsson merged commit 0079e83 into master Feb 19, 2016
@alexandernilsson alexandernilsson deleted the validate_envvar_names branch February 19, 2016 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants