Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves resampling issues due to timezone differences. #467

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Resolves resampling issues due to timezone differences. #467

wants to merge 2 commits into from

Commits on Feb 28, 2022

  1. Resolves resampling issues due to timezone differences. 

    Datafeed sourced from IB API receives timezone info from contractdetails.
This tz info was not passed to num2date() method in lines 275 and 276.
This results in an offset in the point value returned by self._gettmpoint(tm).
This offset distorts the resampling and produces bars at irregular intervals.
Above modifications takes care of the same.

Note: Modified code was tested on `Minute 1` timeframe resampled to 20, 25 & 75 minutes using ibdata and data form local csv file.
    @sohamsjain
    sohamsjain committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    5da562c View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. Merge branch 'mementum:master' into master

    @sohamsjain
    sohamsjain committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    a781e15 View commit details
    Browse the repository at this point in the history