Release/10.3.0 #4669
Merged
Release/10.3.0 #4669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added cypress container (from their official image), may be reconsidered later to choose our own The only minor problem is node JS version mistmatch package.json 18.16.0 docker-compose mermaid 18.16.1 docker-compose cypress 18.16.0 Host option in cypress docker container must be removed in favor of possible configuration option. http://localhost:9000 are currently hard-coded, that is bad Updated ./run script with better documentation and added some styles too it as well Started sankey.spec.js as an example
Fix relative link to theme variables list
Sankey diagrams
Rename workflow jobs
Update all patch dependencies (patch)
…on_destruction Feature/1838 actor creation destruction
…t for C4 diagrams.
Replace the TypeScript `enum {a = "a", b = "b"}` types with
TypeScript's literal types (e.g. `"a" | "b"`).
This is because TypeScript enums are
[_not_ a type-level addition to JavaScript][1], and even the official
TypeScript docs say to be careful when using.
[1]: https://www.typescriptlang.org/docs/handbook/2/everyday-types.html#enums
[`const` assertions where added in TypeScript 3.4][1] and can be used to create enum-like objects in plain JavaScript, that act like TypeScript enums, but has none of the downsides of TypeScript enums. [1]: https://devblogs.microsoft.com/typescript/announcing-typescript-3-4/#const-assertions
[TypeScript enums][1] are an unusual TypeScript feature, because it's one of the only features that is "not a type-level extension of JavaScript". This means TypeScript generates custom code for enums, which can cause a bunch of issues, especially as this custom code can be built differently depending on which bundler you use, and because of this, many people discourage the use of enums: - [The Dangers of TypeScript Enums][2] - [Tidy TypeScript: Prefer union types over enums][3] - [TypeScript: Handbook - Enums # Objects vs Enums][4] I've added an ESLint rule that forbids TypeScript enums, as in most cases, it's better to use string literals instead, e.g. like `type a = "a" | "b" | "c";`. [1]: https://www.typescriptlang.org/docs/handbook/enums.html#string-enums [2]: https://dev.to/azure/the-dangers-of-typescript-enums-55pd [3]: https://fettblog.eu/tidy-typescript-avoid-enums/ [4]: https://www.typescriptlang.org/docs/handbook/enums.html#objects-vs-enums
Update all patch dependencies (patch)
Remove all TypeScript enums and forbid them in ESLint
chore(deps): update all patch dependencies (patch)
…ons-list added Typora to integrations list
2023-07-25
Fix a typo
Already checked in lint.
Co-authored-by: Alois Klink <[email protected]>
…maid into sidv/splitUnicode * 'sidv/splitUnicode' of https://github.com/mermaid-js/mermaid: Update packages/mermaid/src/rendering-util/types.d.ts
Split formatted markdown strings with unicode support.
…js/mermaid into develop * 'develop' of https://github.com/mermaid-js/mermaid: (21 commits) Add comments Update packages/mermaid/src/rendering-util/types.d.ts Remove redundant test. Already checked in lint. Update docs Fix lint Update packages/mermaid/src/rendering-util/splitText.spec.ts Add comments Add tests without Intl.Segmenter Cleanup Fix flowchart failure Handle proper formatting for markdown strings createText to TS Use joiner to split unicode Add types rename handle-markdown-text Add logs Cleanup Use splitLineToFitWidth function Update docs feat: split unicode properly ... * 'develop' of https://github.com/mermaid-js/mermaid: (21 commits) Add comments Update packages/mermaid/src/rendering-util/types.d.ts Remove redundant test. Already checked in lint. Update docs Fix lint Update packages/mermaid/src/rendering-util/splitText.spec.ts Add comments Add tests without Intl.Segmenter Cleanup Fix flowchart failure Handle proper formatting for markdown strings createText to TS Use joiner to split unicode Add types rename handle-markdown-text Add logs Cleanup Use splitLineToFitWidth function Update docs feat: split unicode properly ...
* develop: Add MERMAID_RELEASE_VERSION in sankey
* origin/release/10.3.2:
* master: chore: Rename C4C to C4 update latest news section Corrects name of C4 link Bump zenuml package version
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4669 +/- ##
===========================================
- Coverage 76.03% 45.32% -30.71%
===========================================
Files 137 52 -85
Lines 16296 6645 -9651
Branches 496 18 -478
===========================================
- Hits 12390 3012 -9378
+ Misses 3788 3633 -155
+ Partials 118 0 -118
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
https://www.npmjs.com/package/mermaid/v/10.3.0-rc.1