-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diagram Template #4696
Diagram Template #4696
Conversation
1e5fb79
to
6a89e28
Compare
Rebased it on the fresh development branch |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4696 +/- ##
===========================================
+ Coverage 77.00% 78.21% +1.20%
===========================================
Files 144 144
Lines 14583 10737 -3846
Branches 563 559 -4
===========================================
- Hits 11230 8398 -2832
+ Misses 3243 2214 -1029
- Partials 110 125 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@Yokozuna59 you can commit here directly |
// import { prepareTextForParsing } from './railroadUtils.js'; | ||
|
||
// const originalParse = parser.parse.bind(parser); | ||
// parser.parse = (text: string) => originalParse(prepareTextForParsing(text)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left this lines here intentionally. I don't know how to implement this in a beautiful way, but there is a need to pre-process diagram code before parsing. Even if we dont need it in the majority of the cases we have to provide developers with a possibility to do it in a standard way before parsing, otherwise everyone will do it his own way
I think even closed request is OK as a reference, so as not to pollute our PR's queue, so I am closing it |
📑 Disclaimer! This is only a proposition, not a PR
Simply it makes much easier to see the structure of proposed changes in there, instead of discussing them in the issue.
Originally there was a PR, #4615, but I decided to move this branch to the main repository instead of fork, so that we all could commit here and use it as a reference.
It is initial commit of another bransh, a snapshot of the development at some point where it is relative easy to see what it takes to create a new diagram.
May be it can be implemented as a separate package.
Related #4606
It started as a railroad diagram, but obviously all the
railroad
names must be later on cut from here and replaced by a parameter📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch