-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert diagrams/common/svgDrawCommon.js
to ts
#4724
convert diagrams/common/svgDrawCommon.js
to ts
#4724
Conversation
7d53b92
to
5a2ea7c
Compare
Should I standardize the whole |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4724 +/- ##
============================================
- Coverage 77.18% 46.10% -31.09%
============================================
Files 145 53 -92
Lines 14657 6737 -7920
Branches 581 32 -549
============================================
- Hits 11313 3106 -8207
- Misses 3234 3630 +396
+ Partials 110 1 -109
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…gDrawCommon-to-ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks great to me!
One final thing that's missing is a PR description. IMO, since it's not just a straight JavaScript -> TypeScript conversion (you've also improved error handling), this should be documented in the PR too.
@sidharthv96 @aloisklink Thanks for review, I've update PR description. Feel free to merge the PR if the description looks good. |
Sorry, one final thing, and then I'm happy for you to merge! Can you delete the unused parts of the PR description, like the following bits?
When Mermaid makes a release, users of Mermaid might click on this PR to read more about what has changed. Cleaning up the PR description makes it a look a bit more professional! |
@aloisklink Done. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [mermaid](https://github.com/mermaid-js/mermaid) | [`10.3.1` -> `10.4.0`](https://renovatebot.com/diffs/npm/mermaid/10.3.1/10.4.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/mermaid/10.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/mermaid/10.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/mermaid/10.3.1/10.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/mermaid/10.3.1/10.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mermaid-js/mermaid (mermaid)</summary> ### [`v10.4.0`](https://github.com/mermaid-js/mermaid/releases/tag/v10.4.0) [Compare Source](https://github.com/mermaid-js/mermaid/compare/v10.3.1...v10.4.0) #### Features - feat: Support config in frontmatter. by [@​sidharthv96](https://github.com/sidharthv96) in [mermaid-js/mermaid#4750 - feat(sankey): Show values by [@​sidharthv96](https://github.com/sidharthv96) in [mermaid-js/mermaid#4748 #### Docs - docs: Add development example page. by [@​sidharthv96](https://github.com/sidharthv96) in [mermaid-js/mermaid#4714 - Documentation for [#​2509](https://github.com/mermaid-js/mermaid/issues/2509) by [@​jason-curtis](https://github.com/jason-curtis) in [mermaid-js/mermaid#4740 - Fixes to Docs sidebar, main page and badges by [@​nirname](https://github.com/nirname) in [mermaid-js/mermaid#4742 - Split development documentation into several pages by [@​nirname](https://github.com/nirname) in [mermaid-js/mermaid#4744 - Docs: update Latest News section by [@​huynhicode](https://github.com/huynhicode) in [mermaid-js/mermaid#4768 #### Chores - Update all minor dependencies (minor) by [@​renovate](https://github.com/renovate) in [mermaid-js/mermaid#4732 - Update all patch dependencies (patch) by [@​renovate](https://github.com/renovate) in [mermaid-js/mermaid#4731 - convert `assignWithDepth` to TS by [@​Yokozuna59](https://github.com/Yokozuna59) in [mermaid-js/mermaid#4717 - convert `diagrams/common/svgDrawCommon.js` to ts by [@​Yokozuna59](https://github.com/Yokozuna59) in [mermaid-js/mermaid#4724 - ci(release-drafter): add more release notes categories by [@​aloisklink](https://github.com/aloisklink) in [mermaid-js/mermaid#4752 - chore(deps): update all patch dependencies (patch) by [@​renovate](https://github.com/renovate) in [mermaid-js/mermaid#4753 - standardized pie definitions by [@​Yokozuna59](https://github.com/Yokozuna59) in [mermaid-js/mermaid#4501 - Remove Circular Dependencies by [@​sidharthv96](https://github.com/sidharthv96) in [mermaid-js/mermaid#4761 - chore: Enforce type imports by [@​sidharthv96](https://github.com/sidharthv96) in [mermaid-js/mermaid#4763 - chore: Preview PRs with mermaid-live-editor on Netlify by [@​sidharthv96](https://github.com/sidharthv96) in [mermaid-js/mermaid#4769 #### New Contributors - [@​jason-curtis](https://github.com/jason-curtis) made their first contribution in [mermaid-js/mermaid#4740 **Full Changelog**: mermaid-js/mermaid@v10.3.1...v10.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/levaintech/contented). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
📑 Summary
svgDrawCommon
imports file extension (add.js
postfix).packages/mermaid/src/diagrams/common/common.spec.js
to TSpackages/mermaid/src/diagrams/common/svgDrawCommon.js
to TSsvgDrawCommon
.textData.class
checkundefined
if statement.📋 Tasks
Make sure you
develop
branch