Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make themeVariables typesafe #5631

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

ad1992
Copy link
Contributor

@ad1992 ad1992 commented Jul 8, 2024

📑 Summary

Brief description about the content of your PR.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

Copy link

netlify bot commented Jul 8, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 33eaeb2
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/668ce8b12b3728000851e7a3
😎 Deploy Preview https://deploy-preview-5631--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 5.86%. Comparing base (b263164) to head (33eaeb2).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5631   +/-   ##
=======================================
  Coverage     5.86%   5.86%           
=======================================
  Files          274     273    -1     
  Lines        41086   41075   -11     
  Branches       488     512   +24     
=======================================
  Hits          2408    2408           
+ Misses       38678   38667   -11     
Flag Coverage Δ
unit 5.86% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/mermaid/src/diagrams/xychart/xychartDb.ts 0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/pie/pieRenderer.ts 0.00% <0.00%> (ø)
.../mermaid/src/diagrams/quadrant-chart/quadrantDb.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

argos-ci bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Jul 9, 2024, 7:47 AM

@ad1992 ad1992 marked this pull request as ready for review July 8, 2024 14:52
@ad1992
Copy link
Contributor Author

ad1992 commented Jul 8, 2024

Just type changes so hopefully should be easy to merge, cc @sidharthv96

@ad1992
Copy link
Contributor Author

ad1992 commented Jul 9, 2024

EDIT: I am running into more TS errors so will push for the fixes soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants