refactor!: make fat meta-cli the default
#607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zifeo
previously approved these changes
Mar 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage 74.14% 74.14%
=======================================
Files 111 111
Lines 12425 12425
Branches 1313 1313
=======================================
Hits 9213 9213
Misses 3192 3192
Partials 20 20 ☔ View full report in Codecov by Sentry. |
|
@Yohe-Am small lock conflict then good! |
Yohe-Am
force-pushed
the
fix/MET-394/switch-meta-cli-defaults
branch
from
5249789
to
bda8d3a
Compare
Ah, missed that. Pushes a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the default
meta-clirelease to the fat version (the one that includes thetypegatesubcommand).Motivation and context
Tackles #MET-400
Migration notes
The fat cli requires
libwasmedge.soto be present. Users will need to install or switch to themeta-cli-thinrelease.Checklist